Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: Fix example in 'Client.download_blob_to_file' docstring. #8629

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Storage: Fix example in 'Client.download_blob_to_file' docstring. #8629

merged 1 commit into from
Jul 10, 2019

Conversation

idoshamun
Copy link
Contributor

The argument passed to download_blob_to_file is file although it was defined as file_obj.

@idoshamun
fix example of downloading a blob using a uri
89da295 
The argument passed to `download_blob_to_file` is `file` although it was defined as `file_obj`.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
@tseaver tseaver changed the title fix example of downloading a blob using a uri Storage: Fix example in 'Client.download_blob_to_file' docstring. Jul 10, 2019
@tseaver tseaver added api: storage Issues related to the Cloud Storage API. type: docs Improvement to the documentation for an API. labels Jul 10, 2019
tseaver
tseaver approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idoshamun Thanks for the patch!

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@tseaver tseaver merged commit f94991b into googleapis:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idoshamun @tseaver @googlebot @yoshi-kokoro