-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubSub: Skip two IAM tests for VPCSC #8677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, consistent with what can be found at other places in the project.
I would just like to know what VPCSC is and how can I verify that these two tests should indeed be excluded in that case?
Thanks Peter for reviewing! @bmccutchon may be able to elaborate that better. Brian? |
VPC Service Controls lets you create secure perimeters around projects to prevent data exfiltration. To verify that these client libraries are compatible with it, we need to be able to run the tests in a secure VPCSC environment. When run in this environment, tests can't access resources in other projects. So, in short, tests that access resources in projects separate from the one they run on—e.g. public datasets—need to be skipped or modified to be compatible with VPCSC. That said, these tests don't access resources in other projects, so we probably shouldn't skip them. Instead, we discovered that these tests were actually failing due to another issue that we are able to fix. |
@bmccutchon Thanks for the explanation! @anguillanneuf Since the root cause of the failures can be fixed elsewhere, I presume we do not need to skip the tests, unless it's semi-urgent and we still want to disable them temporarily? If so, please add a comment to the source and open a GitHub issue so that we don't forget to revert the changes later. Or, if we can live with the current state for a bit longer, we should probably close this PR without merging. |
Thanks @bmccutchon and @plamut! I will close this PR for now but keeping the branch just in case! |
Make
test_managing_topic_iam_policy
andtest_managing_subscription_iam_policy
VPCSC-compatible by excluding them when the environment variable GOOGLE_CLOUD_TESTS_IN_VPCSC is set to "true".Reference: #6215