Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): storage_emulator_host should not necessitate google_application_credentials #9455

Merged
merged 1 commit into from
Oct 11, 2019
Merged

fix(storage): storage_emulator_host should not necessitate google_application_credentials #9455

merged 1 commit into from
Oct 11, 2019

Conversation

HemangChothani
Copy link
Contributor

Fixes #9453

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2019
@MaxxleLLC MaxxleLLC force-pushed the Storage_Emulator_Host_Error_Google_Credential branch from a938fd0 to e3daaf9 Compare October 11, 2019 08:48
@crwilcox crwilcox closed this Oct 11, 2019
@crwilcox crwilcox reopened this Oct 11, 2019
@crwilcox crwilcox merged commit 37166af into googleapis:master Oct 11, 2019
@HemangChothani HemangChothani deleted the Storage_Emulator_Host_Error_Google_Credential branch December 17, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@frankyn frankyn frankyn approved these changes

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STORAGE_EMULATOR_HOST should not necessitate GOOGLE_APPLICATION_CREDENTIALS
4 participants
@HemangChothani @crwilcox @frankyn @googlebot