Add BigQuery Access Control #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Allow dataset to get and set the access rules. Allow access rules to be set using the Access DSL. [refs googleapis#202]
blowmage
force-pushed
the
bigquery-access
branch
from
08ceaeb
to
cf2c630
Compare
The use case here is that a view from a different project and/or dataset can be granted access to the dataset's data. We want to allow the view to be either an object or a string.
The table_ref_from_s helper method doesn't depend on the state of a Connection instance object. Move to a class level method to make reuse easier. Stop passing connection object to Dataset::Access because of this change.
blowmage
force-pushed
the
bigquery-access
branch
2 times, most recently
from
6b8856f
to
f3e3b70
Compare
blowmage
force-pushed
the
bigquery-access
branch
from
f3e3b70
to
a8e5bfc
Compare
The default access rules should be used and modified when creating a new dataset using the block syntax.
These are the changes suggested by @quartzmo when pairing on the docs. Thanks!
|
The dual mode setter/getter method |
quartzmo
added a commit
that referenced
this pull request
Sep 2, 2015
Add BigQuery Access Control [closes #202]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
[closes #202]