Skip to content

Commit

Permalink
fix: Remove temporary header encoding workaround (#1935)
Browse files Browse the repository at this point in the history
* fix: Remove header encoding workaround

* remove unused import
  • Loading branch information
tom-andersen committed Nov 9, 2023
1 parent 5da7138 commit 8a4ae5b
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions dev/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ import {
RECURSIVE_DELETE_MIN_PENDING_OPS,
RecursiveDelete,
} from './recursive-delete';
import {stringify} from 'querystring';

export {
CollectionReference,
Expand Down Expand Up @@ -593,21 +592,6 @@ export class Firestore implements firestore.Firestore {
}
}

// TODO (multi-db) Revert this override of gax.routingHeader.fromParams
// after a permanent fix is applied. See b/292075646
// This override of the routingHeader.fromParams does not
// encode forward slash characters. This is a temporary fix for b/291780066
gax.routingHeader.fromParams = params => {
return stringify(params, undefined, undefined, {
encodeURIComponent: (val: string) => {
return val
.split('/')
.map(component => encodeURIComponent(component))
.join('/');
},
});
};

if (this._settings.ssl === false) {
const grpcModule = this._settings.grpc ?? require('google-gax').grpc;
const sslCreds = grpcModule.credentials.createInsecure();
Expand Down

0 comments on commit 8a4ae5b

Please sign in to comment.