feat!: add QoL improvements for converters #1595
Conversation
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: firestore
| /** | ||
| * Update data (for use with [update]{@link DocumentReference#update}) | ||
| * that contains paths mapped to values. Fields that contain dots reference | ||
| * nested fields within the document. | ||
| * nested fields within the document. FieldValues can be passed in | ||
| * as property values. |
There was a problem hiding this comment.
Thinking out loud: Is "property" the right term and does it make it harder to understand? Should we drop it and just call it "values"?
There was a problem hiding this comment.
I wanted to specify "property values" to convey that FieldValues can be set as the value of an object property, but not as the entire object value.
|
Apologies for pinging here, I'm just a bit confused by all the issues that reference this same "need". Has this been published to any version of the "firebase-admin" package, or is it still in the pipeline to be released? Thanks! |
|
This has not been published. We are still working on some details for the implementation that we published for the |
|
I'm a bit confused by the changes implemented for the update() method signature. The update() method does, to the best of my knowledge, not call the converter. Its parameters will not be converted, and must match the "storage format". So it should in fact not be an Am I missing something here? EDIT: I've reported this as #1745 |
Porting from web.
Fixes #1448.