Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update owlbot.py to compile before copying d.ts files from the build folder #2061

Merged
merged 4 commits into from
Jun 6, 2024
Merged

build: update owlbot.py to compile before copying d.ts files from the build folder #2061

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
058b78d
Attempting to fix owlbot proto copying to the types folder by using s…
MarkDuckworth Jun 3, 2024
253ba31
build: Adding compile step to owlbot to generate .d.ts files
MarkDuckworth Jun 4, 2024
5f854f6
Merge remote-tracking branch 'origin' into markduckworth/fix-owlbot-a…
MarkDuckworth Jun 4, 2024
1e2c3b5
Conflict markers
MarkDuckworth Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion owlbot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from synthtool import _tracked_paths
import shutil
from synthtool import shell
from synthtool.log import logger

logging.basicConfig(level=logging.DEBUG)

Expand Down Expand Up @@ -190,7 +191,8 @@
os.chdir("../../")

# Copy types into types/
# These files were generated by node.compile_protos_hermetic() above.
logger.debug("Running compile...")
shell.run(["npm", "run", "compile"], hide_output=True)
s.copy("build/src/v1/firestore*.d.ts", "types/v1")
s.copy("build/src/v1beta1/firestore_client.d.ts", "types/v1beta1")
s.copy("build/protos/firestore*.d.ts", "types/protos")
Expand Down
Loading