Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use any to unblock typescript compilation bug #1012

Merged
merged 2 commits into from
May 27, 2020

Conversation

stephenplusplus
Copy link
Contributor

as any saves the day.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2020
@feywind
Copy link
Collaborator

feywind commented May 27, 2020

Linking to the issue. #1009

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #1012 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          22       22           
  Lines       10615    10615           
  Branches      509      466   -43     
=======================================
  Hits        10107    10107           
  Misses        505      505           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e16384...52759fe. Read the comment docs.

Co-authored-by: Alexander Fenster <github@fenster.name>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels May 27, 2020
@stephenplusplus
Copy link
Contributor Author

@alexander-fenster looks like I made everything confusing by accepting your suggestion :X

@alexander-fenster alexander-fenster added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 27, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@stephenplusplus stephenplusplus merged commit 1e8ced3 into googleapis:master May 27, 2020
@stephenplusplus stephenplusplus deleted the spp--any-fix branch May 27, 2020 21:53
@alexander-fenster
Copy link
Contributor

@stephenplusplus I fixed it! It's weird, I didn't know I will be shown as a co-author if I just suggest a change. Apparently, it used my non-Google email for the commit, or something like that.

@stephenplusplus
Copy link
Contributor Author

Thank you! That is quite weird. Oh well, thanks for catching that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants