Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Vision GA Samples #52

Merged
merged 4 commits into from
Apr 5, 2018
Merged

Vision GA Samples #52

merged 4 commits into from
Apr 5, 2018

Conversation

beccasaurus
Copy link
Contributor

@beccasaurus beccasaurus commented Apr 5, 2018 •
edited
Loading

Updated Vision Samples

TODOs

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@ghost ghost assigned beccasaurus Apr 5, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2018
@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2018
@codecov
Copy link

codecov bot commented Apr 5, 2018 •
edited
Loading

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #52   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          75     75           
=====================================
  Hits           75     75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9582a...41b5046. Read the comment docs.

@beccasaurus beccasaurus requested a review from ace-n April 5, 2018 19:05
@beccasaurus beccasaurus mentioned this pull request Apr 5, 2018
Closed
4 tasks
@beccasaurus beccasaurus changed the title Updated Samples Vision GA Samples Apr 5, 2018
@beccasaurus beccasaurus requested review from jmdobry and removed request for ace-n April 5, 2018 19:08
jmdobry
jmdobry reviewed Apr 5, 2018
View reviewed changes
samples/system-test/detect.test.js
@@ -215,6 +241,8 @@ test(`should read a document from a local file`, async t => {
cwd
);
t.true(output.includes('Google Cloud Platform'));
t.true(output.includes('Word text: Cloud'));
t.true(output.includes('Word confidence: 0.9'));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@beccasaurus beccasaurus merged commit 7753d06 into master Apr 5, 2018
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2018
@stephenplusplus stephenplusplus deleted the updated-samples branch April 6, 2018 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmdobry jmdobry jmdobry approved these changes

Assignees

@beccasaurus beccasaurus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beccasaurus @googlebot @jmdobry