Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove use of old external mock #676

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

a-detiste
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue: there were various attempts before that got stuck by lack of CLA
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@a-detiste a-detiste requested review from a team as code owners July 6, 2024 21:50
Copy link

conventional-commit-lint-gcf bot commented Jul 6, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 6, 2024
@parthea parthea changed the title new attempt at remove use of old external mock fix: remove use of old external mock Jul 29, 2024
@a-detiste
Copy link
Author

This looks a tad too early as Py3.7 is still currently supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants