Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added system test for query offset issue #557

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

gkevinzheng
Copy link
Contributor

System test for bug #547 with some additional changes:

  1. Added new Mergejoin dataset for bug Bug querying with offset #547 (Googlers see b/352377540)
  2. Added options in populate_datastore.py and clear_datastore.py to delete LargeCharacter and Mergejoin kinds from all the namespaces populated by the system tests.

@gkevinzheng gkevinzheng requested review from a team as code owners August 2, 2024 17:12
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/python-datastore API. labels Aug 2, 2024
@daniel-sanche
Copy link
Contributor

How much extra runtime does the new test add?

@gkevinzheng
Copy link
Contributor Author

How much extra runtime does the new test add?

nox -s system -- -k test_mergejoin_query
nox > Running session system-3.8(disable_grpc=False)
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/system-3-8-disable_grpc-false
nox > python -m pip install --pre 'grpcio!=1.52.0rc1'
nox > python -m pip install mock pytest google-cloud-testutils -c /usr/local/google/home/kevzheng/python-datastore/testing/constraints-3.8.txt
nox > python -m pip install six -c /usr/local/google/home/kevzheng/python-datastore/testing/constraints-3.8.txt
nox > python -m pip install -e . -c /usr/local/google/home/kevzheng/python-datastore/testing/constraints-3.8.txt
nox > py.test --quiet --junitxml=system_3.8_sponge_log.xml tests/system -k test_mergejoin_query
..                                                                                           [100%]
-- generated xml file: /usr/local/google/home/kevzheng/python-datastore/system_3.8_sponge_log.xml --
2 passed, 134 deselected in 97.15s (0:01:37)
nox > Session system-3.8(disable_grpc=False) was successful.
nox > Running session system-3.8(disable_grpc=True)
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/system-3-8-disable_grpc-true
nox > python -m pip install --pre 'grpcio!=1.52.0rc1'
nox > python -m pip install mock pytest google-cloud-testutils -c /usr/local/google/home/kevzheng/python-datastore/testing/constraints-3.8.txt
nox > python -m pip install six -c /usr/local/google/home/kevzheng/python-datastore/testing/constraints-3.8.txt
nox > python -m pip install -e . -c /usr/local/google/home/kevzheng/python-datastore/testing/constraints-3.8.txt
nox > py.test --quiet --junitxml=system_3.8_sponge_log.xml tests/system -k test_mergejoin_query
..                                                                                           [100%]
-- generated xml file: /usr/local/google/home/kevzheng/python-datastore/system_3.8_sponge_log.xml --
2 passed, 134 deselected in 103.82s (0:01:43)
nox > Session system-3.8(disable_grpc=True) was successful.
nox > Ran multiple sessions:
nox > * system-3.8(disable_grpc=False): success
nox > * system-3.8(disable_grpc=True): success

I additionally benchmarked how long it takes to populate the dataset, and because of how compact the entries are it takes around 50 seconds to populate the entire dataset.

@gkevinzheng gkevinzheng enabled auto-merge (squash) August 7, 2024 13:56
@gkevinzheng gkevinzheng merged commit ba20019 into main Aug 7, 2024
27 of 28 checks passed
@gkevinzheng gkevinzheng deleted the system-test-mergejoin branch August 7, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/python-datastore API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants