Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Improve Docstrings in modules google/pubsub_v1/services/subscriber #1021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gentris
Copy link

@gentris gentris commented Nov 6, 2023

Improves docstrings on the following modules, by replacing returns with raises:

  • google/pubsub_v1/services/subscriber/async_client.py
  • google/pubsub_v1/services/subscriber/client.py
  • google/pubsub_v1/services/subscriber/transports/grpc.py
  • google/pubsub_v1/services/subscriber/transports/grpc_asyncio.py

Fixes #1020 🦕

@gentris gentris requested review from a team as code owners November 6, 2023 08:38
Copy link

google-cla bot commented Nov 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 6, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Nov 6, 2023
@mukund-ananthu mukund-ananthu added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate Dosctrings in Modules: google/pubsub_v1/services/subscriber
3 participants