Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Open Telemetry Support #1194

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

feat: Add Open Telemetry Support #1194

wants to merge 30 commits into from

Conversation

mukund-ananthu
Copy link
Contributor

Fixes #<issue_number_goes_here> 🦕

@mukund-ananthu mukund-ananthu requested review from a team as code owners June 15, 2024 00:39
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Jun 15, 2024
@mukund-ananthu mukund-ananthu force-pushed the otelPublish branch 4 times, most recently from 356eec2 to 8a3da41 Compare June 15, 2024 01:30
@mukund-ananthu mukund-ananthu self-assigned this Jun 18, 2024
@mukund-ananthu mukund-ananthu marked this pull request as draft June 18, 2024 14:08
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jun 18, 2024
@mukund-ananthu mukund-ananthu force-pushed the otelPublish branch 3 times, most recently from cfff2a4 to 40e3a35 Compare June 18, 2024 15:19
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jun 19, 2024
Avoids race conditions when multiple messages are published using the
same publisher client instance.
We currently start the span after the lock is acquired.
@mukund-ananthu mukund-ananthu force-pushed the otelPublish branch 2 times, most recently from 8309342 to 92a9a6c Compare July 4, 2024 00:37
@mukund-ananthu mukund-ananthu force-pushed the otelPublish branch 4 times, most recently from 49373d4 to eaf6b61 Compare July 7, 2024 05:32
@mukund-ananthu mukund-ananthu force-pushed the otelPublish branch 7 times, most recently from e1d3968 to 8a9916f Compare July 8, 2024 22:01
@yedendramerlyn
Copy link

@mukund-ananthu is there an ETA for landing this PR and releasing an update?

@mukund-ananthu
Copy link
Contributor Author

yedendramerlyn this PR is being split into Publish and Subscribe side PRs. The Publish side PR is out for review: #1241

And the subscribe side PR is WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants