-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Open Telemetry Support #1194
Draft
mukund-ananthu
wants to merge
30
commits into
main
Choose a base branch
from
otelPublish
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: pubsub
Issues related to the googleapis/python-pubsub API.
labels
Jun 15, 2024
mukund-ananthu
force-pushed
the
otelPublish
branch
4 times, most recently
from
June 15, 2024 01:30
356eec2
to
8a3da41
Compare
mukund-ananthu
force-pushed
the
otelPublish
branch
from
June 18, 2024 15:04
8a3da41
to
47d1966
Compare
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: s
Pull request size is small.
labels
Jun 18, 2024
mukund-ananthu
force-pushed
the
otelPublish
branch
3 times, most recently
from
June 18, 2024 15:19
cfff2a4
to
40e3a35
Compare
mukund-ananthu
force-pushed
the
otelPublish
branch
from
June 18, 2024 15:36
40e3a35
to
a7ed13b
Compare
mukund-ananthu
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 18, 2024
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 18, 2024
product-auto-label
bot
added
size: l
Pull request size is large.
and removed
size: m
Pull request size is medium.
labels
Jun 19, 2024
mukund-ananthu
force-pushed
the
otelPublish
branch
from
June 19, 2024 22:17
f92b70f
to
7150c6a
Compare
mukund-ananthu
force-pushed
the
otelPublish
branch
from
June 19, 2024 22:25
7150c6a
to
88890e0
Compare
Avoids race conditions when multiple messages are published using the same publisher client instance.
We currently start the span after the lock is acquired.
mukund-ananthu
force-pushed
the
otelPublish
branch
2 times, most recently
from
July 4, 2024 00:37
8309342
to
92a9a6c
Compare
mukund-ananthu
force-pushed
the
otelPublish
branch
from
July 6, 2024 06:39
92a9a6c
to
cf6e486
Compare
mukund-ananthu
force-pushed
the
otelPublish
branch
4 times, most recently
from
July 7, 2024 05:32
49373d4
to
eaf6b61
Compare
mukund-ananthu
force-pushed
the
otelPublish
branch
from
July 7, 2024 05:43
eaf6b61
to
c9625ff
Compare
mukund-ananthu
force-pushed
the
otelPublish
branch
from
July 7, 2024 21:16
43c39f2
to
f5d13df
Compare
mukund-ananthu
force-pushed
the
otelPublish
branch
from
July 7, 2024 23:46
2154e15
to
6eb054a
Compare
mukund-ananthu
force-pushed
the
otelPublish
branch
7 times, most recently
from
July 8, 2024 22:01
e1d3968
to
8a9916f
Compare
mukund-ananthu
force-pushed
the
otelPublish
branch
from
July 8, 2024 22:06
8a9916f
to
37c16a1
Compare
@mukund-ananthu is there an ETA for landing this PR and releasing an update? |
yedendramerlyn this PR is being split into Publish and Subscribe side PRs. The Publish side PR is out for review: #1241 And the subscribe side PR is WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the googleapis/python-pubsub API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here> 🦕