feat: Add Subscribe Side OpenTelemetry Support #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Current code incorrectly attempts trace context propagation outside of the context of the create span. This results in trace context propagation not occurring and the "googclient_" prefixed attributes never being added to the message. * The fix adds moves the TraceContextPropagation code to the create span function, where its context is available and also adds in a test to verify that the attributes are populated as expected.
* Also fix a mistake introduced in an earlier commit where I only initialize the PublishMessageWrapper with the message when Open Telemetry is enabled. This was resulting in PublishMessageWrapper not None and hence the message not being passed to the sequencers when Open Telemetry is disabled. The tests I've added caught this issue and the issue is now resolved at this point in development.
* Also refactor pytest fixtures by abstracting / reusing OpenTelemetry setup across tests
instead of its fully qualified name
* Fix import ordering * Add typing wherever missing * Update unit tests with additional tests
product-auto-label
bot
added
size: s
mukund-ananthu
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: m
mukund-ananthu
force-pushed
the
otel_subscribe
branch
3 times, most recently
from
b014c28
to
4606288
Compare
mukund-ananthu
force-pushed
the
otel_subscribe
branch
from
4606288
to
8645211
Compare
product-auto-label
bot
added
size: xl
product-auto-label
bot
added
size: m
mukund-ananthu
force-pushed
the
otel_subscribe
branch
from
cfe438e
to
7f0c3f2
Compare
product-auto-label
bot
added
size: xl
mukund-ananthu
force-pushed
the
otel_subscribe
branch
2 times, most recently
from
60bacb7
to
9590aaa
Compare
mukund-ananthu
force-pushed
the
otel_subscribe
branch
3 times, most recently
from
6391fa3
to
d871fd2
Compare
mukund-ananthu
force-pushed
the
otel_subscribe
branch
6 times, most recently
from
547f7e7
to
e1238e0
Compare
Subscriber messages * The wrappers are required to pass the Open Telemetry information along the different code paths
mukund-ananthu
force-pushed
the
otel_subscribe
branch
from
e1238e0
to
535c2eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕