-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: f-string formatting #789
Conversation
I am not sure why 2 tests failed, let me know if further input is needed from me. |
Yep, for the conventionalcommits message, you just need to amend the commit message to be "cleanup: f-string formatting". I thought editing the title there would do it, but seems not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Mostly looks correct, except for a few spots.
@Mariatta, thank you, great catches!
Which I do not yet know how to solve. My Python interpreter seems to be Python 3.8 (screenshot of pottom right corner of PyCharm): |
Oh that's strange. I'll check on why that's happening. For now I'll just run the lint myself and add the commit, once you push up your changes to address @Mariatta's comments. |
@Breathtender, just read your reply now, sorry; in the meantime I figured out what's going on and were able to run |
Addressing @Mariatta suggestions now... |
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
I think I have addressed the suggestions. My last commit was the result of a typo & forgetting to run |
No, it'll automatically roll all your commits together, and so the first commit message is ultimately the one that matters. |
Thanks for making those adjustments! I'll wait for @Mariatta's approval on the changes requested, but this is looking good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
As discussed here, code in this repo appears directly in the documentation. (An example, there are hundreds.) This commit introduces f-strings to increase readability of both code and documentation.
Fixes #785 🦕