Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show difference in integration test #2684

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Apr 23, 2024

In this PR:

  • Show file diff in integration tests.

I manually edited a line in test branch and this is the test result:

Difference in google-cloud-alloydb/src/main/java/com/google/cloud/alloydb/v1/AlloyDBAdminClient.java:
--- 

+++ 

@@ -774,7 +774,7 @@

 

   /**

    * Constructs an instance of AlloyDBAdminClient, using the given stub for making calls. This is

-   * for advanced usage - prefer using create(AlloyDBAdminSettings) - manually added.

+   * for advanced usage - prefer using create(AlloyDBAdminSettings).

    */

   public static final AlloyDBAdminClient create(AlloyDBAdminStub stub) {

     return new AlloyDBAdminClient(stub);

Error: Process completed with exit code 1.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 23, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review April 23, 2024 15:34
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner April 23, 2024 15:34
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 23, 2024
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@@ -11,6 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import difflib
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see that there is a native Python lib for this!

@JoeWang1127 JoeWang1127 enabled auto-merge (squash) April 23, 2024 16:13
@JoeWang1127 JoeWang1127 merged commit 971e4a3 into main Apr 23, 2024
29 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/output-IT-diff branch April 23, 2024 16:41
lqiu96 pushed a commit that referenced this pull request May 22, 2024
In this PR:
- Show file diff in integration tests.

I manually edited a line in test branch and this is the test result:
```
Difference in google-cloud-alloydb/src/main/java/com/google/cloud/alloydb/v1/AlloyDBAdminClient.java:
--- 

+++ 

@@ -774,7 +774,7 @@

 

   /**

    * Constructs an instance of AlloyDBAdminClient, using the given stub for making calls. This is

-   * for advanced usage - prefer using create(AlloyDBAdminSettings) - manually added.

+   * for advanced usage - prefer using create(AlloyDBAdminSettings).

    */

   public static final AlloyDBAdminClient create(AlloyDBAdminStub stub) {

     return new AlloyDBAdminClient(stub);

Error: Process completed with exit code 1.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants