chore: make the showcase scripts to automatically prepare the generator jar #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
JoeWang1127
reviewed
Sep 6, 2024
showcase/README.md
Outdated
| @@ -76,7 +76,11 @@ Note: | |||
|
|
|||
| ## Update the Golden Showcase Files | |||
|
|
|||
| Open a new terminal window in the root project directory. | |||
| Open a new terminal window in the root project directory. Note that the | |||
There was a problem hiding this comment.
nit: one sentence per line.
There was a problem hiding this comment.
Thanks, done.
JoeWang1127
approved these changes
Sep 6, 2024
diegomarquezp
added
automerge
|
|
gcf-merge-on-green
bot
removed
the
automerge: exact
gcf-merge-on-green
bot
deleted the
fix-showcase-generator-well-known-location
branch
lqiu96
pushed a commit
that referenced
this pull request
Sep 11, 2024
…or jar (#3171) The recent changes in the hermetic library generation workflow make it necessary for the environment to have a well-known folder where the generator jar is assumed to be located. This PR sets up the generator jar in such location when running showcase golden tests or using the `-Pupdate` profile. More details in the [development guide](https://github.com/googleapis/sdk-platform-java/blob/main/library_generation/DEVELOPMENT.md#the-hermetic-builds-well-known-folder)
ldetmer
pushed a commit
that referenced
this pull request
Sep 17, 2024
…or jar (#3171) The recent changes in the hermetic library generation workflow make it necessary for the environment to have a well-known folder where the generator jar is assumed to be located. This PR sets up the generator jar in such location when running showcase golden tests or using the `-Pupdate` profile. More details in the [development guide](https://github.com/googleapis/sdk-platform-java/blob/main/library_generation/DEVELOPMENT.md#the-hermetic-builds-well-known-folder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes in the hermetic library generation workflow make it necessary for the environment to have a well-known folder where the generator jar is assumed to be located.
This PR sets up the generator jar in such location when running showcase golden tests or using the
-Pupdateprofile.More details in the development guide