Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(python): kokoro sample configs have hardcoded repo python-pubsub #1166

Closed
parthea opened this issue Jul 23, 2021 · 0 comments · Fixed by #1167
Closed

bug(python): kokoro sample configs have hardcoded repo python-pubsub #1166

parthea opened this issue Jul 23, 2021 · 0 comments · Fixed by #1167
Assignees
@parthea
Labels
lang: python Issues specific to Python. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Jul 23, 2021

In the python templated .kokoro samples files, the repository is hardcoded as python-pubsub for all repos.
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 23, 2021
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. lang: python Issues specific to Python. and removed samples Issues that are directly related to samples. labels Jul 23, 2021
@parthea parthea self-assigned this Jul 23, 2021
@parthea parthea mentioned this issue Jul 23, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 23, 2021
@parthea
chore: fix kokoro config for samples (#1167)
dd05f9d 
Fixes #1166 

I tested these changes by running the following commands after cloning synthtool
```
git checkout fix-kokoro-sample-config
docker build -t testkokoro -f docker/owlbot/python/Dockerfile .
```

Once the docker image was built, I ran the following command in the root of python-aiplatform

```
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo testkokoro
```

which produced the following changes
```
partheniou@partheniou-vm-1:~/git/python-aiplatform$ git diff .kokoro
diff --git a/.kokoro/samples/python3.6/periodic-head.cfg b/.kokoro/samples/python3.6/periodic-head.cfg
index f9cfcd3..88d5235 100644
--- a/.kokoro/samples/python3.6/periodic-head.cfg
+++ b/.kokoro/samples/python3.6/periodic-head.cfg
@@ -7,5 +7,5 @@ env_vars: {
 
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
-    value: "github/python-pubsub/.kokoro/test-samples-against-head.sh"
+    value: "github/python-aiplatform/.kokoro/test-samples-against-head.sh"
 }
diff --git a/.kokoro/samples/python3.7/periodic-head.cfg b/.kokoro/samples/python3.7/periodic-head.cfg
index f9cfcd3..88d5235 100644
--- a/.kokoro/samples/python3.7/periodic-head.cfg
+++ b/.kokoro/samples/python3.7/periodic-head.cfg
@@ -7,5 +7,5 @@ env_vars: {
 
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
-    value: "github/python-pubsub/.kokoro/test-samples-against-head.sh"
+    value: "github/python-aiplatform/.kokoro/test-samples-against-head.sh"
 }
diff --git a/.kokoro/samples/python3.8/periodic-head.cfg b/.kokoro/samples/python3.8/periodic-head.cfg
index f9cfcd3..88d5235 100644
--- a/.kokoro/samples/python3.8/periodic-head.cfg
+++ b/.kokoro/samples/python3.8/periodic-head.cfg
@@ -7,5 +7,5 @@ env_vars: {
 
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
-    value: "github/python-pubsub/.kokoro/test-samples-against-head.sh"
+    value: "github/python-aiplatform/.kokoro/test-samples-against-head.sh"
 }
diff --git a/.kokoro/samples/python3.9/periodic-head.cfg b/.kokoro/samples/python3.9/periodic-head.cfg
index f9cfcd3..88d5235 100644
--- a/.kokoro/samples/python3.9/periodic-head.cfg
+++ b/.kokoro/samples/python3.9/periodic-head.cfg
@@ -7,5 +7,5 @@ env_vars: {
 
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
-    value: "github/python-pubsub/.kokoro/test-samples-against-head.sh"
+    value: "github/python-aiplatform/.kokoro/test-samples-against-head.sh"
 }
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
lang: python Issues specific to Python. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix kokoro config for samples googleapis/synthtool
1 participant
@parthea