Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): skip docfx in main presubmit #889

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Dec 23, 2020

Skip docfx session in the main presubmit (called Kokoro) since it is already covered by the separate Kokoro: docs-presubmit check in CI.

See googleapis/python-bigquery@e68281e and googleapis/python-bigquery#425

Needs change to kokoro configs in 348715194 to allow NOX_SESSION env var in docs-presubmit.

@busunkim96 busunkim96 requested a review from a team as a code owner December 23, 2020 00:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 23, 2020
@busunkim96 busunkim96 merged commit fb53b6f into master Jan 8, 2021
@busunkim96 busunkim96 deleted the skip-docfx-in-main branch January 8, 2021 17:32
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 19, 2021
I added this accidentally in #889. `NOX_SESSION` should be passed down if it is set but not marked required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants