This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Modify async to async_ to avoid reserved keyword clash. #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crwilcox
changed the title
crwilcox
force-pushed
the
3-7-compatibility
branch
from
6d197d7
to
b2675d6
Compare
seii-saintway
previously approved these changes
Mar 11, 2020
francois-baptiste
previously approved these changes
Mar 12, 2020
There was a problem hiding this comment.
work like a charm, thanks!
(pip install git+https://github.com/crwilcox/pydatalab.git@3-7-compatibility)
crwilcox
dismissed stale reviews from francois-baptiste and seii-saintway
via
9d618df
ojarjur
approved these changes
Mar 20, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #711 by refactoring use of a reserved keyword.
Add test pass for Python 3.7