Rust gpu up #12
Merged
Rust gpu up #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This nearly works with naga, but we're blocked on EmbarkStudios/rust-gpu#689
raphlinus
approved these changes
Oct 31, 2021
There was a problem hiding this comment.
Looks good, and works fine for me. (I ran into rust-lang/rustup#988 which is a risk of using a pinned nightly toolchain, but that's nothing wrong with this patch). Thanks!
rust-gpu-toy/src/main.rs
Outdated
| }) | ||
| .await | ||
| .expect("error finding adapter"); | ||
| let features = wgpu::Features::PUSH_CONSTANTS; | ||
| let features = wgpu::Features::PUSH_CONSTANTS /* | wgpu::Features::SPIRV_SHADER_PASSTHROUGH */; |
There was a problem hiding this comment.
TIL about wgpu::util::make_spirv and the fact it doesn't need this. Generally I prefer not to have commented-out code, so maybe remove this?
There was a problem hiding this comment.
Yeah, it depends on whether the shader can be translated using naga or not. I think the main rust-gpu repo is still using passthrough, but I also think that they should be able to use naga now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the version of rust-gpu we use to my branch https://github.com/DJMcNab/rust-gpu/tree/more-decorations, which has @charles-r-earp's EmbarkStudios/rust-gpu#692 to fix EmbarkStudios/rust-gpu#689, plus a fix to actually make it usable for the types of image we use.
It also upgrades wgpu to 0.11.
This time, we don't even need to bypass naga; it all works now 🎉
As a side note, we're still affected by the 'transiently required' issue as mentioned in EmbarkStudios/rust-gpu#778. That is, if we enable the
Int8capability, then we can use&&in the shader. No 8 bit integers are actually generated however.