Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Agones to 1.29.0 and Open Match to 1.7.0 #20

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Upgrade Agones to 1.29.0 and Open Match to 1.7.0 #20

merged 1 commit into from
Mar 10, 2023

Conversation

govargo
Copy link
Collaborator

@govargo govargo commented Mar 4, 2023

This PR has a upgrade to Agones and Open Match and change of installing for Open Match

  • Upgrade GKE Kubernetes version from 1.22 to 1.24
  • Upgrade Agones from 1.27.0 to 1.29.0
  • Upgrade Open Match from 1.5.0 to 1.7.0
  • Change instaling way for Open Match ※1

※1 One of the Open Match installing way is YAML apply. The default YAML requires more than 4.5 cpu cores, because the StatefulSet's Redis has 3 containers(redis, sentinel, metrics) requre each 0.5 cpus(= total 1.5 cores) and StatefulSet has 3 reqlica(= 1.5cores * 3Pod = total 4.5 cores)

@govargo
Copy link
Collaborator Author

govargo commented Mar 4, 2023

I'll assign review after 3/7.

@govargo govargo requested a review from kemurayama March 7, 2023 08:42
@kemurayama kemurayama self-assigned this Mar 9, 2023
Copy link
Collaborator

@kemurayama kemurayama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @govargo

As helm is introduced, it is now the necessary tool for Space Agon.

Would you revise README.md in accordance with your PR ?

- [helm](https://helm.sh/) (Optional)

Makefile Show resolved Hide resolved
@govargo
Copy link
Collaborator Author

govargo commented Mar 9, 2023

Would you revise README.md in accordance with your PR ?

I added the helm section.
I think helm is the neccesary, not optional. So, I removed (Optional).

kemurayama
kemurayama previously approved these changes Mar 10, 2023
Makefile Show resolved Hide resolved
@kemurayama kemurayama self-requested a review March 10, 2023 01:20
@kemurayama kemurayama dismissed their stale review March 10, 2023 01:21

need to remove the duplicate line.

@govargo
Copy link
Collaborator Author

govargo commented Mar 10, 2023

@kemurayama
What do you mean about need to remove the duplicate line.?
Could you please point out the line with link?

Thank you

@kemurayama
Copy link
Collaborator

@govargo
Copy link
Collaborator Author

govargo commented Mar 10, 2023

Thank you for your point out @kemurayama.

It's my fault. I fixed this duplicate line.

Copy link
Collaborator

@kemurayama kemurayama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @govargo, thanks for updating. LGTM

@kemurayama kemurayama merged commit 2fe040a into googleforgames:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants