Add Helm Chart and make skaffold compatible with Helm #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Skaffold template
Add minikube with docker driver command
govargo
reviewed
Apr 4, 2023
|
Hi @govargo, thank you for reviewing. I added helper templates. |
|
Let me override parameters for GKE. I'll update later |
Extracted Git tags from `build.sh`. Add new command called `make install-local`
|
Hi @govargo, it's ready to review. |
|
@kemurayama maybe, there are some reviews existing in frontend part.
It looks there still be Others look good for me. |
|
@govargo |
govargo
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables you to install Space Agon application with Helm.
Helm is the package manager tool for kubernetes that simplifies the deployment and management.
It is also used in Agones and Open Match.
In addition, I also added support for Skaffold with Helm.
Skaffold is a tool for building, pushing and deploying your application. It enables you to iterate quickly and deploy changes.
You can also test Helm Chart changes with skaffold.
Close #9