Select existing "Advanced settings" page if any #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please clarify a little why 1a020ed is required? I don't see any error messages in the console similar to the ones mentioned in the linked issue. |
|
I see now that's not needed, only one additional change in previous commit is needed. Update: Changed. |
Related issue: - uBlockOrigin/uBlock-issues#591 Additionally, I added a link to the logger in the "About" pane in the dashboard in order to be able to access the logger without having to go through the popup panel.
hawkeye116477
force-pushed
the
advancedEx
branch
from
1a020ed
to
a1be7fa
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when you wanted to open advanced settings and clicked multiple times, then same multiple tabs would open. Now should be only one.
Changes from 1a020ed are semi related (required).