Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of CodeMirror in "Advanced settings" page #271

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

hawkeye116477
Copy link
Contributor

No description provided.

@JustOff
Copy link
Collaborator

JustOff commented Oct 10, 2020

Is it normal that I see no visual effect from this?

@hawkeye116477
Copy link
Contributor Author

hawkeye116477 commented Oct 10, 2020

You should see line numbers and that's all for now. Gorhill added syntax coloring one year later, but seems that direct porting that won't be possible, maybe I look at that some another day.

@JustOff
Copy link
Collaborator

JustOff commented Oct 10, 2020

Ah, ok, thanks.

@JustOff JustOff merged commit 8c61d80 into gorhill:master Oct 10, 2020
@hawkeye116477 hawkeye116477 deleted the cm_advanced branch October 10, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants