Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gorhill/uBlock#2179 #275

Merged
merged 1 commit into from
Nov 7, 2020
Merged

fix gorhill/uBlock#2179 #275

merged 1 commit into from
Nov 7, 2020

Conversation

hawkeye116477
Copy link
Contributor

All is good described in issue description and can be reproduced with for example ppe.pl and EasyList.

In short when logger is opened and you then disable filterlist which had filter which was in logger, then when you click on that filter, blank message will be displayed, but should be written that Static filter could not be found in any of the currently enabled filter lists.

@JustOff
Copy link
Collaborator

JustOff commented Nov 7, 2020

Could you please place loggerStaticFilteringFinderSentence2 right after loggerStaticFilteringFinderSentence1?

Co-authored-by:  gorhill <585534+gorhill@users.noreply.github.com>
@hawkeye116477
Copy link
Contributor Author

Done.

@JustOff
Copy link
Collaborator

JustOff commented Nov 7, 2020

Thank you.

@JustOff JustOff merged commit a6b9213 into gorhill:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants