-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not cname-uncloak same-origin network requests
Same-origin as per URL address of the main document. Currently the fix only affect top-level pages. Related issue: - uBlockOrigin/uBlock-issues#1062 The previous behavior can be restored by toggling the advanced setting `cnameIgnoreRootDocument` to `false`.
- Loading branch information
Showing
1 changed file
with
23 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
161a175
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gorhill Still happening at youtube.com homepage --
uBO dev build, Firefox Nightly.
161a175
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue you were seeing above is probably due to the fact that uBO clears the cname-uncloaking cache at regular interval and thus losing information about same-originess. The new code will evaluate same-originess using a different approach which does not depends on
main_frame
network requests: c143ded161a175
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you finally able to reproduce this issue ?
161a175
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn´t reproduce, but I understood this is most certainly caused by the fact that the cname-uncloaking cache is reset regularly -- which would cause the issue you were seeing, especially likely on long-lived pages.