Support keyboard shortcut to open popup panel

Related discussion: - https://www.reddit.com/r/uBlockOrigin/comments/dt47s0/
gorhill · Nov 9, 2019 · e2fdc1b · e2fdc1b
1 parent 7bf5ac0
commit e2fdc1b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/platform/firefox/manifest.json b/platform/firefox/manifest.json
@@ -19,6 +19,8 @@
  }
  },
  "commands": {
+ "_execute_browser_action": {
+ },
  "launch-element-zapper": {
  "description": "__MSG_popupTipZapper__"
  },

diff --git a/src/js/shortcuts.js b/src/js/shortcuts.js
@@ -204,7 +204,12 @@
  const template = document.querySelector('#templates .commandEntry');
  const tbody = document.querySelector('.commandEntries tbody');
  for ( const command of commands ) {
- if ( command.description === '' ) { continue; }
+ if (
+ typeof command.description !== 'string' ||
+ command.description === '' )
+ {
+ continue;
+ }
  const tr = template.cloneNode(true);
  tr.setAttribute('data-name', command.name);
  tr.querySelector('.commandDesc').textContent = command.description;