Skip to content

Commit

Permalink
Do not select background images as best candidate in picker
Browse files Browse the repository at this point in the history 
Related feedback:
- https://www.reddit.com/r/uBlockOrigin/comments/s2lrm0/picker_cant_select_and_block_this/
  • Loading branch information
@gorhill
gorhill committed Jan 13, 2022
1 parent 2b65f25 commit ebaa8a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/js/scriptlets/epicker.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ const netFilterFromElement = function(elem) {
const pattern = mergeStrings(urls);


if ( bestCandidateFilter === null ) {
if ( bestCandidateFilter === null && elem.matches('html,body') === false ) {
bestCandidateFilter = {
type: 'net',
filters: candidates,
Expand Down

1 comment on commit ebaa8a8

@gwarser
Copy link
Contributor

@gwarser gwarser commented on ebaa8a8 Jan 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this: https://www.reddit.com/r/uBlockOrigin/comments/re5nct/block_element_sliders_not_showing_on_some_webpages/

But I see an issue on https://old.reddit.com/r/techsupport/ when you click here:

image

Nothing is selected as default.

Please sign in to comment.