fix: optimise cpu usage 🚀 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
hi @muxbert, could you test this fix using this yarn add ssh://git@github.gorhom/react-native-animated-tabbar#fix/optimise-cpu-usagethanks |
|
I did this to install it. Now it's a lot better, but I tried to intentionally break it by switching the tabs then it causes the same issue. So if a user liked the animation and kept switching between tabs the same thing will happen. Luckily in real devices, this doesn't seem to happen the same as in simulator. Anyway, for now, this is great. Thanks a lot for your hard efforts. |
|
glad to hear that , thanks for reporting and testing 👍 |
gorhom
added a commit
that referenced
this pull request
May 9, 2020
* master: fix: optimise cpu usage 🚀 (#32) chore: improve types by (@nandorojo) (#34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing #31
https://imgur.com/a/UIzNyrc