Fixed --alertmanager.cluster.peers #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
gotjosh
approved these changes
Jun 16, 2021
| @@ -63,7 +63,7 @@ | |||
| $.util.mapToFlags($.alertmanager_args) + | |||
| if isHA then | |||
| ['--alertmanager.cluster.listen-address=[$(POD_IP)]:%s' % $._config.alertmanager.gossip_port] + | |||
| ['--alertmanager.cluster.peers=%s' % peer for peer in peers] | |||
| ['--alertmanager.cluster.peers=%s' % std.join(',', peers)] | |||
There was a problem hiding this comment.
Is this a good time to also fix the double --?
There was a problem hiding this comment.
Not now, otherwise will trigger a rollout in all envs :)
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Dec 20, 2021
…anager-peers Fixed --alertmanager.cluster.peers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The
--alertmanager.cluster.peersis expected to have multiple peers a single comma-separated string, instead of specifying multiple times the CLI flag. This PR fixes it.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]