Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change min-step to 15s to show better detail. #340

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

bboreham
Copy link
Contributor

What this PR does:
$__rate_interval will be floored at 4x this quantity, so 15s lets us see faster transients than the previous value of 1m.

Which issue(s) this PR fixes:
Fixes #339

Checklist

  • CHANGELOG.md updated

$__rate_interval will be floored at 4x this quantity, so 15s lets us see
faster transients than the previous value of 1m.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham bboreham requested a review from a team as a code owner June 25, 2021 17:06
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Unrelated from this PR: I've also noticed in the in the queries.libsonnet dashboard we've some queries with the rate time window hardcoded to [1m]. Should we change it to [$__rate_interval] like other dashboards?

@bboreham
Copy link
Contributor Author

we've some queries with the rate time window hardcoded to [1m]

The main difference I'm aware of is that the window will get bigger as you zoom out with [$__rate_interval]. So spikes will get more rounded off. At small time ranges it will still hit the floor so no difference; at large time ranges [1m] is very spiky so a smoother picture is easier to read.

Empirically on my machine it jumps from 1m to 2m between 24h and 2 days, and both are pretty spiky, so I would agree we should change queries.libsonnet to [$__rate_interval] like other dashboards.

Incidentally I found Beorn wrote an explanation which suggests that interval was intended to tell Grafana the scrape interval, so this PR is bringing the world into alignment.

@bboreham bboreham merged commit 90a7809 into main Jun 30, 2021
@bboreham bboreham deleted the min-step-15s branch June 30, 2021 08:36
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
Change min-step to 15s to show better detail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query 'min step' of 1m loses fine detail
3 participants