Skip to content

Commit

Permalink
Mark some memberlist and ring flags as advanced (#138)
Browse files Browse the repository at this point in the history
  • Loading branch information
andyasp committed Feb 10, 2022
1 parent 624e792 commit c3b4825
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion kv/memberlist/tcp_transport.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type TCPTransportConfig struct {
PacketWriteTimeout time.Duration `yaml:"packet_write_timeout" category:"advanced"`

// Transport logs lot of messages at debug level, so it deserves an extra flag for turning it on
TransportDebug bool `yaml:"-"`
TransportDebug bool `yaml:"-" category:"advanced"`

// Where to put custom metrics. nil = don't register.
MetricsRegisterer prometheus.Registerer `yaml:"-"`
Expand Down
4 changes: 2 additions & 2 deletions ring/ring.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,10 @@ var (
// Config for a Ring
type Config struct {
KVStore kv.Config `yaml:"kvstore"`
HeartbeatTimeout time.Duration `yaml:"heartbeat_timeout"`
HeartbeatTimeout time.Duration `yaml:"heartbeat_timeout" category:"advanced"`
ReplicationFactor int `yaml:"replication_factor"`
ZoneAwarenessEnabled bool `yaml:"zone_awareness_enabled"`
ExcludedZones flagext.StringSliceCSV `yaml:"excluded_zones"`
ExcludedZones flagext.StringSliceCSV `yaml:"excluded_zones" category:"advanced"`

// Whether the shuffle-sharding subring cache is disabled. This option is set
// internally and never exposed to the user.
Expand Down

0 comments on commit c3b4825

Please sign in to comment.