Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache subrings returned by Ring.ShuffleShardWithLookback() #283

Merged
merged 9 commits into from
Apr 27, 2023
Merged

Cache subrings returned by Ring.ShuffleShardWithLookback() #283

merged 9 commits into from
Apr 27, 2023

Commits on Apr 13, 2023

  1. Rename test to follow same convention as other tests.

    @charleskorn
    charleskorn committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    5ba5809 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Cache subrings returned by Ring.ShuffleShardWithLookback().

    @charleskorn
    charleskorn committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    e49ff16 View commit details
    Browse the repository at this point in the history

  2. Add changelog entry.

    @charleskorn
    charleskorn committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    e98f347 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Add test for different lookback windows.

    @charleskorn
    charleskorn committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    41373ff View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Merge branch 'main' into charleskorn/cache-shuffleshardwithlookback

    @charleskorn
    charleskorn committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    1b357dd View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Clarify variable names.

    @charleskorn
    charleskorn committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ce9e279 View commit details
    Browse the repository at this point in the history

  2. Cache subrings for different lookback periods separately.

    @charleskorn
    charleskorn committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c7bc124 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Address PR feedback: make names clearer and add more explanatory comm… 

    …ents.
    @charleskorn
    charleskorn committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e4bd156 View commit details
    Browse the repository at this point in the history

  2. Address PR feedback: improve test.

    @charleskorn
    charleskorn committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    d87c519 View commit details
    Browse the repository at this point in the history