Re-export ring.GenerateTokens() #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/issue-1042
branch
from
08aa2a5
to
a95c7b9
Compare
pstibrany
approved these changes
Jun 13, 2023
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/issue-1042
branch
from
c8b36cd
to
b4ac838
Compare
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Jun 13, 2023
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Jun 14, 2023
…lation to reduce risk of memory leaks (#5236) * Update dskit. * Use ring.DoUntilQuorumWithoutSuccessfulContextCancellation to ensure no contexts are leaked. * Fix race in tests. * Bring in grafana/dskit#320 * Fix breaking change introduced in grafana/dskit#318.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In one of previous PRs we removed
GenerateTokens()from theringpackage. This PR re-exportsGenerateTokens()(for backwards compatibility) because it is used by some tests outside ofdskit.Moreover, this PR exports
ring.NewRandomTokenGenerator(), so that generation of random tokens generation could be done by callingring.NewRandomTokenGenerator().GenerateTokens()outside ofdskit.Part of grafana/mimir#4736
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]