Feature: Add spanlogger package #42
Merged
Commits on Oct 7, 2021
-
Instrument test exporter for OpenTracing.
Also: - Move SpanLogger out of chunk package and reuse it. - Update the logging in the test-exporter to use gokit. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
-
Add comment to appease linter.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
-
Log opening of span at debug level (#1075)
Signed-off-by: Bryan Boreham <bryan@weave.works>
-
Signed-off-by: Bryan Boreham <bryan@weave.works>
-
Adds FromContext to spanlogger package. (#2089)
* Adds FromContext to spanlogger package. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Removes noop spanlogger for clarity/ Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Add missing comment on exported function. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
-
Fix logger context when creating a spanLogger from context. (#2519)
* Fix logger context when creating a spanLogger from context. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Syntax error. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
-
Be consistent with span logging, set error=true and use otlog.Error (…
…#2970) * Make use of spanlogger when functions that generate spans result in an error, this is so we consistently have the error=true tag set. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Add spanlogger Error to errcheck exclude Signed-off-by: Callum Styan <callumstyan@gmail.com> * Review cleanup. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address more review feedback. Signed-off-by: Callum Styan <callumstyan@gmail.com> * We need nolint comments on these lines if we want to assign the ctx in attempt to avoid use of the incorrect ctx in the future. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Globally exclude SpanLogger.Error() errcheck Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
-
Added -querier.max-query-lookback and fixed -querier.max-query-into-f…
…uture (#3452) * Added querier max-query-lookback and fixed max-query-into-future Signed-off-by: Marco Pracucci <marco@pracucci.com> * Updated PR number Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed dead code Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added warning for the deprecated flag Signed-off-by: Marco Pracucci <marco@pracucci.com> * Addressed review comments Signed-off-by: Marco Pracucci <marco@pracucci.com>
-
Support custom log.Logger instances in spanlogger (#3480)
* support custom log.Logger instances in spanlogger Signed-off-by: Robert Fratto <robertfratto@gmail.com> * Update pkg/util/spanlogger/spanlogger.go Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com> Signed-off-by: Robert Fratto <robertfratto@gmail.com> * add test, fix bug Signed-off-by: Robert Fratto <robertfratto@gmail.com> * ignore errors from logging to test spanlogger Signed-off-by: Robert Fratto <robertfratto@gmail.com> Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
-
Move some utility functions out of
utiland into their own packages…… (#3734) * separate out some util packages Signed-off-by: Kevin Minehart <kmineh0151@gmail.com> * use goimports with -local Signed-off-by: Kevin Minehart <kmineh0151@gmail.com> * refactor: reduce the number of transitive imports when using math and logging functions Signed-off-by: Kevin Minehart <kmineh0151@gmail.com> * add deprecation warning to pkg/log/log.go Signed-off-by: Kevin Minehart <kmineh0151@gmail.com>
-
#4147 added
tenant_idtag to tracing spans (#4186)* #4147 1. added logic to add tag `tenant_id` to tracing spans if tenant is defined in context. 2. added additional tracing spans to merge_querier's methods Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com> * #4147 fixed errors reported by linters Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com> * #4147 1.changed value of tenant_id tag in tracing span from string value to array 2. removed import alias for spanlogger Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com> * #4147 1. fixed tests 2. fixed name of the spans in mergeQuerier Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com> * #4147 updated CHANGELOG.md Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com> * #4147 passed method's span context to mergeDistinctStringSlice function to create inner spans under this context Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com> * #4147 added mocktracer package for testing purpose Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com> * #4147 fixed code style and removed redundant context param that is not used in callback function Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com> * #4147 fixed code style Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
-
Move pkg/util/spanlogger to root
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
-
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.