instrumented gate: observe permitted and non-permitted queries separately #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Apr 2, 2024
4 tasks
…tely This distinction helps when debugging increased congestion on a gate.
dimitarvdimitrov
force-pushed
the
dimtiar/gate/count-premitted-vs-non-permitted-queries
branch
from
6e1d78e
to
bdcced0
Compare
thanks for the review. I added further separation of outcomes between context cancelled and deadline exceeded (and now "other"). Also added a changelog entry. I rebase the branch, so you can look at only the last 2 commits if you want partial diff. |
|
i also mistakenly committed some other changes; cleared them out in another 2 commits |
pracucci
deleted the
dimtiar/gate/count-premitted-vs-non-permitted-queries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This distinction helps when debugging increased congestion on a gate.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]