This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Monitor rss, vsz, cpu usage and page faults #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsaj
suggested changes
Aug 30, 2018
There was a problem hiding this comment.
You have a procfs.Proc in both MemoryReporter and ProcessReporter and are calling proc.NewStat() on both. This seems very redundant.
I think you should just move the vsz and rss stats into the ProcessReporter.
Right now for metrics that are coming from the kernel as opposed to the internal go runtime you have
- memory.process.virtual_memory_bytes.gauge64
- memory.process.resident_memory_bytes.gauge64
- process.minor_page_faults.counter64
- process.major_page_faults.counter64
- process.cpu_seconds_total.counter64
The rss/vsz and page_fault metrics are all related to memory usage of the process (not the runtime). It seems weird to have them named differently.
I think the metrics should just be
- process.virtual_memory_bytes.gauge64
- process.resident_memory_bytes.gauge64
- process.minor_page_faults.counter64
- process.major_page_faults.counter64
- process.cpu_seconds_total.counter64
was accidentally changed. -5min is most useful for fresh installs.
to get latest schema and sort all json keys no functional change
seems to work fine in all testing dep needs it to be pinned apparently
woodsaj
approved these changes
Aug 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1019
a bunch of useful new stats. interesting to see relation between cpu usage, GC, page faults and memory usage.
in addition to extra stats, no longer display bytes_sys by default anymore because it's not very useful.
before:
after: