This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Docker grafana automatic provisioning #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
force-pushed
the
docker-grafana-automatic-provisioning
branch
from
a059716
to
4b22597
Compare
mainly needed so we can mount the approriate directories to auto-provision in grafana. Later we will likely categorize further based on what they're for.
this solves some of the panels showing errors like:
Datasource named ${DS_GRAPHITE} was not found
note: * docker-cluster now also has prometheus datasource just like docker-dev-custom-cfg-kafka * docker-standard now always autoloads datasources, so no need for people to manually do it
(exact same thing as docker-dev-custom-cfg-kafka)
note: * as opposed to the "all environments get all dashboards" approach we had before, now each environment only loads dashboards relevant (e.g. only dockprom for those monitored with prometheus, and the standard env has only the main dashboard) * update docks for docker-standard as it now auto-loads the dashboard
no longer needed as we use grafana auto provisioning
Dieterbe
force-pushed
the
docker-grafana-automatic-provisioning
branch
from
4b22597
to
92f5274
Compare
|
rebased on master |
woodsaj
approved these changes
Sep 10, 2018
Dieterbe
force-pushed
the
docker-grafana-automatic-provisioning
branch
from
92f5274
to
112cca5
Compare
|
thanks for reviewing @woodsaj 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changeset is big, but if you follow commit by commit it'll simplify things. lots of it is renames too