This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
fix panic caused by multiple closes of pluginFatal channel #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiple input plugins, or multiple goroutines within a plugin could try to close the same pluginFatal channel, which results in a panic. We fix this by switching to a context and cancelFunc, which can be called multiple times fix #870
|
fun fact: tried to test this with docker-dev-custom-cfg-kafka and but the code should be simple enough to be merged by only code reviewing |
woodsaj
approved these changes
Oct 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple input plugins, or multiple goroutines within a plugin
could try to close the same pluginFatal channel, which
results in a panic.
We fix this by switching to a context and cancelFunc, which
can be called multiple times
fix #870