This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
fix bigtable idx pruning + index-rules.conf pruning for bigtable idx #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dieterbe
commented
Oct 24, 2018
•
Dieterbe
commented
Dieterbe
force-pushed
the
index-rules-bigtable
branch
from
e17125a
to
c621e30
Compare
1) both the at-runtime pruning of the memory index, as well as the on-startup initialisation of the cassandra index group metrics by nameWithTags, whereas the on-startup init of the bigtable index did it by name. So even if all defs for a.b;foo=bar are stale, bigtable idx wouldn't prune it if there's e.g. a non stale a.b;foo=quux, in contrast with cassandra and memory index which consider these separate series for pruning. We fix it here, and also clarify some things a bit, making the cassandra and bigtable index implementation on par and easily diffable. 2) implement index-rules.conf based pruning for bigtable idx, rather than the old max-stale mechanism. fix #1108
Dieterbe
force-pushed
the
index-rules-bigtable
branch
from
c621e30
to
7e1d50e
Compare
Dieterbe
changed the title
woodsaj
reviewed
Oct 26, 2018
| pruned, err := b.MemoryIdx.Prune(oldest) | ||
| statPruneDuration.Value(time.Since(pre)) | ||
| func (b *BigtableIdx) Prune(now time.Time) ([]idx.Archive, error) { | ||
| log.Info("bigtable-idx: start pruning of series") |
There was a problem hiding this comment.
bigtable-idx: starting prune of series ?
|
this doesn't break config because bigtable support hasn't been released yet |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.