This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
idx: better log msg formatting, include more info #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, in each caller of bigtableIdx.deleteRow log an error, so longer needed in bigtableIdx.deleteRow itself fix #1116
woodsaj
approved these changes
Oct 26, 2018
I think this is fine for now. As we marshal the metricDefs attributes to []bytes, I dont see how a specific metricDef could be rejected while others are ok. So any failure should be a general failure that affects all metricsDefs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, in each caller of bigtableIdx.deleteRow log an error,
so longer needed in bigtableIdx.deleteRow itself
fix #1116
note, unlike cassandraIdx, in the bigtableIdx i haven't found a nice way yet to print a failing metricdef, since we send in batches and do some interesting reducing of the input set. we can revisit this later.