Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

fix render latency queries + remove old dashboards #1192

Merged
merged 3 commits into from
Dec 31, 2018
Merged

Conversation

Dieterbe
Copy link
Contributor

No description provided.

in #548, specifically a9fbf99

we removed this metric:
// metric api.request_handle is how long it takes to handle a render request
reqHandleDuration = stats.NewLatencyHistogram15s32("api.request_handle")

in favor of:

* `api.request.<path>.status.<code>`
* `api.request.<path>.handle`
* `api.request.<path>.size`

but we still have to make the adjustment in a few places.
it was still using old metrictank statsd metrics (!!)
it's for an old grafana fork that we no longer work on
Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dieterbe Dieterbe merged commit f99f2bd into master Dec 31, 2018
@Dieterbe Dieterbe added this to the vnext milestone Feb 11, 2019
@Dieterbe Dieterbe deleted the httpstats2 branch March 27, 2019 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants