Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

make archive table not required for MT startup #1235

Merged
merged 3 commits into from
Mar 12, 2019
Merged

make archive table not required for MT startup #1235

merged 3 commits into from
Mar 12, 2019

Conversation

replay
Copy link
Contributor

@replay replay commented Mar 12, 2019

With this change, on startup MT will still create the mt_index_archive table if the create-keyspace flag is true. But if it is false it won't error on startup, because actually that table is not required for it to run, it's only required for the mt-index-prune utility.

Fixes: #1234

@replay
Copy link
Contributor Author

replay commented Mar 12, 2019

Tested in my QA instance:

  • Ran the mt-index-prune utility with -create-keyspace=false and it errored with the expected message
  • Started a read MT while the archive table did not exist, it came up correctly. The read MTs have -create-keyspace turned set to false
  • Ran the mt-index-prune utility without specifying -create-keyspace (default is true) and the table got created correctly

idx/cassandra/cassandra.go Outdated Show resolved Hide resolved
@woodsaj
Copy link
Member

woodsaj commented Mar 12, 2019

lgtm other then minor typo in a comment.

@replay replay merged commit 5c9ebe4 into master Mar 12, 2019
@Dieterbe Dieterbe deleted the issue_1234 branch March 27, 2019 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants