This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Expose new prometheus metric discarded_samples_total #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on merging raintank/schema#25 |
woodsaj
reviewed
Apr 12, 2019
woodsaj
reviewed
Apr 12, 2019
fkaleo
force-pushed
the
expose_discarded_samples_prometheus
branch
from
2a1b452
to
7fd05c4
Compare
The metric takes a reason with values among: - sample-out-of-order - received-too-late - invalid-timestamp" - invalid-interval - invalid-orgID" - invalid-name - invalid-mtype - invalid-tag-format - unknown-point-id Fixes #1203
fkaleo
force-pushed
the
expose_discarded_samples_prometheus
branch
from
7a17e61
to
fa816aa
Compare
|
Manual testing can be performed using:
|
Dieterbe
reviewed
Apr 16, 2019
mdata/init.go
Outdated
| @@ -15,6 +15,13 @@ import ( | |||
| log "github.com/sirupsen/logrus" | |||
| ) | |||
|
|
|||
| const ( | |||
| discardReasonLabel = "reason" | |||
There was a problem hiding this comment.
seems weird to declare this as a global since it only has 1 use, and for org we don't do this.
fkaleo
commented
Apr 17, 2019
Dieterbe
force-pushed
the
expose_discarded_samples_prometheus
branch
from
93aabb6
to
2cc492a
Compare
|
Note, this PR does not include |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric takes a reason with values among:
Fixes #1203