This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Prevent blocked go routines to hang forever (issue #1332) #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsaj
reviewed
May 28, 2019
api/cluster.go
Outdated
| }, 1) | ||
| } | ||
|
|
||
| responses := make(chan response, len(peerGroups)) |
There was a problem hiding this comment.
the responses chan doesnt need to be buffered.
woodsaj
reviewed
May 28, 2019
replay
changed the title
robert-milan
approved these changes
May 29, 2019
|
Tested in my QA instance and in the docker stack |
|
how does this solve the problem? |
|
The problem it solves it more related to how the method was exiting, and leaving running goroutines with absolutely no way to proceed. The goroutines would be blocked on a channel that they could never send to. They were all getting deadlocked. This way, the ctx will finish at some point and those goroutines will now exit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not tested yet.
Fixes #1332