This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Fix active series stats decrement #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also: #1327
|
I believe that https://github.com/grafana/metrictank/pull/1336/files#diff-051eec914f9c2892a0d9f0d2a4d87336R1568 addresses the previous issue of subtracting more than it was supposed to. I don't think this was being accounted for in earlier iterations. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue while decrementing certain memory stats from a partitioned index. This does not close the issue, but addresses the most urgent problem.
See also: #1327