This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
implement all jaeger config options #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanson7
reviewed
Jun 4, 2019
|
correct. I think this is acceptable since we're still pre 1.0 |
replay
reviewed
Jun 6, 2019
replay
reviewed
Jun 6, 2019
replay
reviewed
Jun 6, 2019
replay
approved these changes
Jun 6, 2019
tested with:
add-tags = foo=var,term=${WAIT_HOSTS:defalut-shouldnotseeme},term2=${TERM2:default-should-see-me},term3=${term3},bar=baz
Dieterbe
force-pushed
the
configurable-jaeger-client
branch
from
1c289f1
to
2760eb8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1060
replaces #1228
replaces #1055
this way, we use MT's config system (unlike 1055) to set all config options the library supports, in particular, any sampler type (unlike 1228)