This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
fix prometheus input plugin resetting its config at startup #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to fix configuration reset During the startup process, the prometheus module is first configured using `prometheus.ConfigSetup()` and `prometheus.ConfigProcess()`, then the Handler is started. The problem is that `ConfigSetup()` is called from `Start()`, which makes the configuration re-initialize to its default values. Removing the call from `Start()` solve the issue.
beorn-
force-pushed
the
fix_partitionID_prometheus
branch
from
5c03395
to
3927378
Compare
beorn-
changed the title
Dieterbe
changed the title
|
thanks @beorn- ! |
Dieterbe
approved these changes
Jun 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the startup process, the prometheus module is first configured using
prometheus.ConfigSetup()andprometheus.ConfigProcess(), then the Handler is started. The problem is thatConfigSetup()is called fromStart(), which makes the configuration re-initialize to its default values. Removing the call fromStart()solve the issue.