This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Meta tag enrichment #1433
Merged
Meta tag enrichment #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
force-pushed
the
meta_tag_enrichment
branch
from
65fee12
to
47dc1c4
Compare
|
Rebased onto the latest master. there were a few conflicts due to the schema changes |
robert-milan
approved these changes
Aug 21, 2019
replay
force-pushed
the
meta_tag_enrichment
branch
from
fc6995a
to
714ef7f
Compare
|
I rebased onto the latest master |
also update docs accordingly, and while doing so fix some copy-paste mistakes in the docs
this results in a pretty serious improvement: benchcmp /tmp/enrichment.before /tmp/enrichment.after benchmark old ns/op new ns/op delta BenchmarkMetaTagEnricher-12 666 526 -21.02% benchmark old allocs new allocs delta BenchmarkMetaTagEnricher-12 6 1 -83.33% benchmark old bytes new bytes delta BenchmarkMetaTagEnricher-12 66 18 -72.73%
replay
force-pushed
the
meta_tag_enrichment
branch
from
831a84b
to
7b1a530
Compare
|
I ran all the tag related benchmarks before and after these modifications, there are no significant changes afaict. In some cases there is a slight slow-down up to 20%, which is kind of expected simply because now more work is being done before returning the query results. So I'll go ahead and merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements step 4 of this list: #660 (comment)
Originally the plan was to first implement it without cache, but since it was easy I've already added the enrichment cache as well.
I'll need to create another small PR which adds the meta tags / meta tag values into the autoComplete requests for tags/values. Once this is done then I think the meta tag feature should be ready to start testing it.